Refresh Provider data every week #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwbrown2
reviewed
Nov 7, 2019
| @@ -920,7 +920,23 @@ func (a *Accesses) recordPrices() { | |||
| return strings.Split(key, ",") | |||
| } | |||
|
|
|||
| // Create job to refresh provider prices every week | |||
| // TODO: Make configurable? | |||
| refreshProviderCosts := NewTimedJob(7*24*time.Hour, func() error { | |||
There was a problem hiding this comment.
So if this fails, retry currently happens in a week? Seems fine for an initial implementation but just wanted to ask
There was a problem hiding this comment.
Yeah - it just doesn't feel like something we want to retry. I'm not sure what type of "failure" can happen outside of failing to download the sku list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat over architected for what I ended up with, but due to some inconsistencies with lack of etags on GCP responses, I've punted for now and just added this directly to the run loop.
Reset()if the data is force reloaded?