Changes for edge case where idle would not be shared between allocations. #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires https://github.com/kubecost/cost-analyzer-frontend/pull/354
The way in which idle is being shared between allocations means that if a resource (cpu/gpu/ram) does not have any cost other than idle, the idle costs for that resource would disappear. E.g. below there are no GPU costs but the idle one, so currently that $27 would be distributed by weight to each allocation. However, since there are no other GPU costs, the weights would all be zero, effectively deleting the cost.
With this + the frontend pull, the costs instead go into a manufactured idle row which only keeps the costs for a resource which would not be distributed:
Caveats: