Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for edge case where idle would not be shared between allocations. #883

Merged
merged 1 commit into from Sep 2, 2021

Conversation

kaelanspatel
Copy link
Collaborator

Requires https://github.com/kubecost/cost-analyzer-frontend/pull/354

The way in which idle is being shared between allocations means that if a resource (cpu/gpu/ram) does not have any cost other than idle, the idle costs for that resource would disappear. E.g. below there are no GPU costs but the idle one, so currently that $27 would be distributed by weight to each allocation. However, since there are no other GPU costs, the weights would all be zero, effectively deleting the cost.
image

With this + the frontend pull, the costs instead go into a manufactured idle row which only keeps the costs for a resource which would not be distributed:
image

Caveats:

  • Because the idle is not being distributed, there's no way to normalize it, so the total idle either appears or doesn't.
  • There is also no way AFAIK to associate the costs with a specific asset besides the share, so it may be that, depending on the idle sharing type, the total cost of an allocation view drill-down might be inconsistent with the asset view for that asset. E.g. if you share by cluster then breakdown by node, even if the undistributed idle is associated with that node, it will still be filtered out when drilling down.

Copy link
Collaborator

@Sean-Holcomb Sean-Holcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great Comments

@kaelanspatel kaelanspatel merged commit f90ee32 into develop Sep 2, 2021
@michaelmdresser michaelmdresser deleted the kaelan-gpuidle branch June 23, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants