ClusterMapInfo Injects Local Cluster Info on Empty #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmdresser
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
On initial startup, or if cost-model had not been running for the last 5 minutes, the initial prometheus query to get cluster info would always return 0 data (since the cost-model emits this metric). To account for variance here, we always include the local cluster info in the event that the map is empty.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
How was this PR tested?
Turning off cost-model deployment for 10 minutes, starting up. Observing the bug no longer occurs.