Remove storage autoscaler from Sentinel spec (#991)

Signed-off-by: Arnob kumar saha arnob@appscode.com
kubedb · Oct 10, 2022 · 197a256 · 197a256
1 parent 2dae1fa
commit 197a256
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 80 deletions.
diff --git a/apis/autoscaling/v1alpha1/openapi_generated.go b/apis/autoscaling/v1alpha1/openapi_generated.go
diff --git a/apis/autoscaling/v1alpha1/redis_sentinel_types.go b/apis/autoscaling/v1alpha1/redis_sentinel_types.go
@@ -66,17 +66,12 @@ type RedisSentinelAutoscalerSpec struct {
 	OpsRequestOptions *RedisSentinelOpsRequestOptions `json:"opsRequestOptions,omitempty"`
 
 	Compute *RedisSentinelComputeAutoscalerSpec `json:"compute,omitempty"`
-	Storage *RedisSentinelStorageAutoscalerSpec `json:"storage,omitempty"`
 }
 
 type RedisSentinelComputeAutoscalerSpec struct {
 	Sentinel *ComputeAutoscalerSpec `json:"sentinel,omitempty"`
 }
 
-type RedisSentinelStorageAutoscalerSpec struct {
-	Sentinel *StorageAutoscalerSpec `json:"sentinel,omitempty"`
-}
-
 type RedisSentinelOpsRequestOptions struct {
 	// Timeout for each step of the ops request in second. If a step doesn't finish within the specified timeout, the ops request will result in failure.
 	Timeout *metav1.Duration `json:"timeout,omitempty"`

diff --git a/apis/autoscaling/v1alpha1/redis_sentinel_webhook.go b/apis/autoscaling/v1alpha1/redis_sentinel_webhook.go
@@ -50,10 +50,6 @@ func (in *RedisSentinelAutoscaler) Default() {
 func (in *RedisSentinelAutoscaler) setDefaults() {
 	in.setOpsReqOptsDefaults()
 
-	if in.Spec.Storage != nil {
-		setDefaultStorageValues(in.Spec.Storage.Sentinel)
-	}
-
 	if in.Spec.Compute != nil {
 		setDefaultComputeValues(in.Spec.Compute.Sentinel)
 	}

diff --git a/apis/autoscaling/v1alpha1/zz_generated.deepcopy.go b/apis/autoscaling/v1alpha1/zz_generated.deepcopy.go
diff --git a/crds/autoscaling.kubedb.com_redissentinelautoscalers.yaml b/crds/autoscaling.kubedb.com_redissentinelautoscalers.yaml
@@ -96,25 +96,6 @@ spec:
                   timeout:
                     type: string
                 type: object
-              storage:
-                properties:
-                  sentinel:
-                    properties:
-                      expansionMode:
-                        enum:
-                        - Offline
-                        - Online
-                        type: string
-                      scalingThreshold:
-                        format: int32
-                        type: integer
-                      trigger:
-                        type: string
-                      usageThreshold:
-                        format: int32
-                        type: integer
-                    type: object
-                type: object
             required:
             - databaseRef
             type: object