Add validator to check negative number of replicas. (#1124)

Signed-off-by: pritamdas99 <pritam@appscode.com>
kubedb · Jan 22, 2024 · a28b266 · a28b266
1 parent cc189c3
commit a28b266
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/apis/kubedb/v1alpha2/solr_webhook.go b/apis/kubedb/v1alpha2/solr_webhook.go
@@ -158,6 +158,11 @@ func (s *Solr) ValidateCreateOrUpdate() field.ErrorList {
 	}
 
 	if s.Spec.Topology == nil {
+		if s.Spec.Replicas != nil && *s.Spec.Replicas <= 0 {
+			allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("replicas"),
+				s.Name,
+				"number of replicas can not be less be 0 or less"))
+		}
 		err := solrValidateVolumes(&s.Spec.PodTemplate)
 		if err != nil {
 			allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("podTemplate").Child("spec").Child("volumes"),
@@ -176,11 +181,6 @@ func (s *Solr) ValidateCreateOrUpdate() field.ErrorList {
 			allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("topology").Child("data"),
 				s.Name,
 				".spec.topology.data can't be empty in cluster mode"))
-			if s.Spec.Replicas != nil && *s.Spec.Replicas <= 0 {
-				allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("replicas"),
-					s.Name,
-					"number of replicas can not be less be 0 or less"))
-			}
 		}
 		if s.Spec.Topology.Data.Replicas != nil && *s.Spec.Topology.Data.Replicas <= 0 {
 			allErr = append(allErr, field.Invalid(field.NewPath("spec").Child("topology").Child("data").Child("replicas"),