Skip to content

Commit

Permalink
Review DBA crds (#516)
Browse files Browse the repository at this point in the history 
Signed-off-by: Tamal Saha <tamal@appscode.com>
  • Loading branch information
@tamalsaha
tamalsaha committed May 19, 2020
1 parent bc1e13f commit c66fda4
Show file tree
Hide file tree
Showing 56 changed files with 4,661 additions and 4,818 deletions.
3 changes: 1 addition & 2 deletions api/api-rules/violation_exceptions.list
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,MongoDBModificationRequestStatus,Conditions
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,MySQLModificationRequestList,Items
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,MySQLModificationRequestStatus,Conditions
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,MySQLVerticalScalingSpec,Containers
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,PerconaXtraDBModificationRequestList,Items
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,PerconaXtraDBModificationRequestStatus,Conditions
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,PgBouncerModificationRequestList,Items
Expand All @@ -207,7 +208,6 @@ API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,ProxySQLModificationRequestStatus,Conditions
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,RedisModificationRequestList,Items
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,RedisModificationRequestStatus,Conditions
API rule violation: list_type_missing,kubedb.dev/apimachinery/apis/dba/v1alpha1,VerticalScale,Containers
API rule violation: names_match,k8s.io/api/core/v1,AzureDiskVolumeSource,DataDiskURI
API rule violation: names_match,k8s.io/api/core/v1,ContainerStatus,LastTerminationState
API rule violation: names_match,k8s.io/api/core/v1,DaemonEndpoint,Port
Expand Down Expand Up @@ -254,4 +254,3 @@ API rule violation: names_match,k8s.io/apimachinery/pkg/util/intstr,IntOrString,
API rule violation: names_match,k8s.io/apimachinery/pkg/util/intstr,IntOrString,StrVal
API rule violation: names_match,k8s.io/apimachinery/pkg/util/intstr,IntOrString,Type
API rule violation: names_match,kmodules.xyz/offshoot-api/api/v1,ContainerRuntimeSettings,IONice
API rule violation: names_match,kubedb.dev/apimachinery/apis/dba/v1alpha1,MySQLUpdateSpec,CurrentStatefulSetOrdinal
40 changes: 20 additions & 20 deletions api/crds/bindata.go
View file

Large diffs are not rendered by default.

19 changes: 9 additions & 10 deletions api/crds/dba.kubedb.com_elasticsearchmodificationrequests.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ spec:
type: object
spec:
description: ElasticsearchModificationRequestSpec is the spec for ElasticsearchModificationRequest
object
properties:
databaseRef:
description: Specifies the Elasticsearch reference
Expand All @@ -59,8 +58,8 @@ spec:
TODO: Add other useful fields. apiVersion, kind, uid?'
type: string
type: object
scale:
description: Specifies the scaling info of Elasticsearch Object
horizontalScaling:
description: HorizontalScaling specifies the horizontal scaling.
properties:
client:
description: Number of client nodes
Expand All @@ -76,29 +75,29 @@ spec:
type: integer
type: object
type:
description: Specifies the modification request type; ScaleUp, ScaleDown,
Upgrade etc.
description: 'Specifies the modification request type: Upgrade, HorizontalScaling,
VerticalScaling etc.'
enum:
- Upgrade
- HorizontalScaling
- VerticalScaling
- VolumeExpansion
- Restart
- RotateCertificates
type: string
update:
description: Specifies the field information that needed to be updated
upgrade:
description: Specifies the field information that needed to be upgraded
properties:
targetVersion:
description: Specifies the ElasticsearchVersion object name
description: Specifies the MySQLVersion object name
type: string
type: object
required:
- databaseRef
- type
type: object
status:
description: ElasticsearchModificationRequestStatus is the status for elasticsearch
version
description: ElasticsearchModificationRequestStatus is the status for ElasticsearchModificationRequest
properties:
conditions:
description: Conditions applied to the request, such as approval or
Expand Down
91 changes: 82 additions & 9 deletions api/crds/dba.kubedb.com_etcdmodificationrequests.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ metadata:
app.kubernetes.io/name: kubedb
name: etcdmodificationrequests.dba.kubedb.com
spec:
additionalPrinterColumns:
- JSONPath: .spec.type
name: Type
type: string
- JSONPath: .status.phase
name: Status
type: string
- JSONPath: .metadata.creationTimestamp
name: Age
type: date
group: dba.kubedb.com
names:
categories:
Expand All @@ -20,6 +30,8 @@ spec:
singular: etcdmodificationrequest
preserveUnknownFields: false
scope: Namespaced
subresources:
status: {}
validation:
openAPIV3Schema:
properties:
Expand All @@ -36,35 +48,96 @@ spec:
metadata:
type: object
spec:
description: EtcdModificationRequestSpec is the spec for elasticsearch version
description: EtcdModificationRequestSpec is the spec for EtcdModificationRequest
properties:
databaseRef:
description: Specifies the etcd reference
properties:
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Add other useful fields. apiVersion, kind, uid?'
type: string
type: object
type:
description: 'Specifies the modification request type: Upgrade, HorizontalScaling,
VerticalScaling etc.'
enum:
- Upgrade
- HorizontalScaling
- VerticalScaling
- VolumeExpansion
- Restart
- RotateCertificates
type: string
upgrade:
description: Specifies the field information that needed to be upgraded
properties:
targetVersion:
description: Specifies the MySQLVersion object name
type: string
type: object
required:
- databaseRef
- type
type: object
status:
description: EtcdModificationRequestStatus is the status for elasticsearch
version
description: EtcdModificationRequestStatus is the status for EtcdModificationRequest
properties:
conditions:
description: Conditions applied to the request, such as approval or
denial.
items:
properties:
lastUpdateTime:
description: timestamp for the last update to this condition
lastTransitionTime:
description: Last time the condition transitioned from one status
to another. This should be when the underlying condition changed. If
that is not known, then using the time when the API field changed
is acceptable.
format: date-time
type: string
message:
description: human readable message with details about the request
state
description: A human readable message indicating details about
the transition. This field may be empty.
type: string
observedGeneration:
description: If set, this represents the .metadata.generation
that the condition was set based upon. For instance, if .metadata.generation
is currently 12, but the .status.condition[x].observedGeneration
is 9, the condition is out of date with respect to the current
state of the instance.
format: int64
type: integer
reason:
description: brief reason for the request state
description: The reason for the condition's last transition in
CamelCase. The specific API may choose whether or not this field
is considered a guaranteed API. This field may not be empty.
type: string
status:
description: Status of the condition, one of True, False, Unknown.
type: string
type:
description: request approval state, currently Approved or Denied.
description: Type of condition in CamelCase or in foo.example.com/CamelCase.
Many .condition.type values are consistent across resources
like Available, but because arbitrary conditions can be useful
(see .node.status.conditions), the ability to deconflict is
important.
type: string
required:
- lastTransitionTime
- message
- reason
- status
- type
type: object
type: array
observedGeneration:
description: observedGeneration is the most recent generation observed
for this resource. It corresponds to the resource's generation, which
is updated on mutation by the API Server.
format: int64
type: integer
phase:
type: string
type: object
type: object
version: v1alpha1
Expand Down
92 changes: 82 additions & 10 deletions api/crds/dba.kubedb.com_memcachedmodificationrequests.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@ metadata:
app.kubernetes.io/name: kubedb
name: memcachedmodificationrequests.dba.kubedb.com
spec:
additionalPrinterColumns:
- JSONPath: .spec.type
name: Type
type: string
- JSONPath: .status.phase
name: Status
type: string
- JSONPath: .metadata.creationTimestamp
name: Age
type: date
group: dba.kubedb.com
names:
categories:
Expand All @@ -20,6 +30,8 @@ spec:
singular: memcachedmodificationrequest
preserveUnknownFields: false
scope: Namespaced
subresources:
status: {}
validation:
openAPIV3Schema:
properties:
Expand All @@ -36,36 +48,96 @@ spec:
metadata:
type: object
spec:
description: MemcachedModificationRequestSpec is the spec for elasticsearch
version
description: MemcachedModificationRequestSpec is the spec for MemcachedModificationRequest
properties:
databaseRef:
description: Specifies the Memcached reference
properties:
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Add other useful fields. apiVersion, kind, uid?'
type: string
type: object
type:
description: 'Specifies the modification request type: Upgrade, HorizontalScaling,
VerticalScaling etc.'
enum:
- Upgrade
- HorizontalScaling
- VerticalScaling
- VolumeExpansion
- Restart
- RotateCertificates
type: string
upgrade:
description: Specifies the field information that needed to be upgraded
properties:
targetVersion:
description: Specifies the MySQLVersion object name
type: string
type: object
required:
- databaseRef
- type
type: object
status:
description: MemcachedModificationRequestStatus is the status for elasticsearch
version
description: MemcachedModificationRequestStatus is the status for MemcachedModificationRequest
properties:
conditions:
description: Conditions applied to the request, such as approval or
denial.
items:
properties:
lastUpdateTime:
description: timestamp for the last update to this condition
lastTransitionTime:
description: Last time the condition transitioned from one status
to another. This should be when the underlying condition changed. If
that is not known, then using the time when the API field changed
is acceptable.
format: date-time
type: string
message:
description: human readable message with details about the request
state
description: A human readable message indicating details about
the transition. This field may be empty.
type: string
observedGeneration:
description: If set, this represents the .metadata.generation
that the condition was set based upon. For instance, if .metadata.generation
is currently 12, but the .status.condition[x].observedGeneration
is 9, the condition is out of date with respect to the current
state of the instance.
format: int64
type: integer
reason:
description: brief reason for the request state
description: The reason for the condition's last transition in
CamelCase. The specific API may choose whether or not this field
is considered a guaranteed API. This field may not be empty.
type: string
status:
description: Status of the condition, one of True, False, Unknown.
type: string
type:
description: request approval state, currently Approved or Denied.
description: Type of condition in CamelCase or in foo.example.com/CamelCase.
Many .condition.type values are consistent across resources
like Available, but because arbitrary conditions can be useful
(see .node.status.conditions), the ability to deconflict is
important.
type: string
required:
- lastTransitionTime
- message
- reason
- status
- type
type: object
type: array
observedGeneration:
description: observedGeneration is the most recent generation observed
for this resource. It corresponds to the resource's generation, which
is updated on mutation by the API Server.
format: int64
type: integer
phase:
type: string
type: object
type: object
version: v1alpha1
Expand Down
17 changes: 8 additions & 9 deletions api/crds/dba.kubedb.com_mongodbmodificationrequests.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ spec:
metadata:
type: object
spec:
description: MongoDBModificationRequestSpec is the spec for mongodb modification
request
description: MongoDBModificationRequestSpec is the spec for MongoDBModificationRequest
properties:
databaseRef:
description: Specifies the Elasticsearch reference
Expand All @@ -60,29 +59,29 @@ spec:
type: string
type: object
type:
description: Specifies the modification request type; ScaleUp, ScaleDown,
Upgrade etc.
description: 'Specifies the modification request type: Upgrade, HorizontalScaling,
VerticalScaling etc.'
enum:
- Upgrade
- HorizontalScaling
- VerticalScaling
- VolumeExpansion
- Restart
- RotateCertificates
type: string
update:
description: Specifies the field information that needed to be updated
upgrade:
description: Specifies the field information that needed to be upgraded
properties:
targetVersion:
description: Specifies the ElasticsearchVersion object name
description: Specifies the MySQLVersion object name
type: string
type: object
required:
- databaseRef
- type
type: object
status:
description: MongoDBModificationRequestStatus is the status for mongodb
modification request
description: MongoDBModificationRequestStatus is the status for MongoDBModificationRequest
properties:
conditions:
description: Conditions applied to the request, such as approval or
Expand Down
Loading

0 comments on commit c66fda4

Please sign in to comment.