New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with update-gofmt.sh script #155
Comments
Can be seen in PR #154 |
According to @srivatsav123 , there can be an issue with gometalinter which is not taking -w flag in gofmt |
@sids-b - Hi no issue with both update-gofmt.sh script and gometalinter ..But the version which is used to test gofmt must be 1.11 or above(go version 1.11). If its below 1.11 there may be possiblity of not formating correctly..(Possibly some bug so that some lines will not get formatted) |
@sids-b you can close the issue.. |
We are using go version 1.11... you can check .travis.yml for the same :) |
yes agree..But in local host ..if we use version 1.9.1..!..Then there will be missmatch in formatting..Please use go version 1.11 in local host and try.. |
So as suggested by Manju, we need to suggest to use golang v1.11 during development |
What happened:
Running hack/update-gofmt.sh still gives gofmt warning in CI
What you expected to happen:
No warnings in CI
How to reproduce it (as minimally and precisely as possible):
Clone the code
Run hack/update-gofmt.sh
The text was updated successfully, but these errors were encountered: