Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with update-gofmt.sh script #155

Closed
sids-b opened this issue Feb 11, 2019 · 7 comments
Closed

Issue with update-gofmt.sh script #155

sids-b opened this issue Feb 11, 2019 · 7 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@sids-b
Copy link
Member

sids-b commented Feb 11, 2019

What happened:
Running hack/update-gofmt.sh still gives gofmt warning in CI

What you expected to happen:
No warnings in CI

How to reproduce it (as minimally and precisely as possible):
Clone the code
Run hack/update-gofmt.sh

@sids-b sids-b added the kind/bug Categorizes issue or PR as related to a bug. label Feb 11, 2019
@sids-b
Copy link
Member Author

sids-b commented Feb 11, 2019

Can be seen in PR #154

@sids-b
Copy link
Member Author

sids-b commented Feb 11, 2019

According to @srivatsav123 , there can be an issue with gometalinter which is not taking -w flag in gofmt

@srivatsav123
Copy link
Contributor

@sids-b - Hi no issue with both update-gofmt.sh script and gometalinter ..But the version which is used to test gofmt must be 1.11 or above(go version 1.11). If its below 1.11 there may be possiblity of not formating correctly..(Possibly some bug so that some lines will not get formatted)

@srivatsav123
Copy link
Contributor

@sids-b you can close the issue..

@sids-b
Copy link
Member Author

sids-b commented Feb 12, 2019

We are using go version 1.11... you can check .travis.yml for the same :)

@srivatsav123
Copy link
Contributor

yes agree..But in local host ..if we use version 1.9.1..!..Then there will be missmatch in formatting..Please use go version 1.11 in local host and try..

@sids-b
Copy link
Member Author

sids-b commented Feb 14, 2019

So as suggested by Manju, we need to suggest to use golang v1.11 during development

@sids-b sids-b closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants