make test failed: can't load package: named files must be .go files:xxx

[shenkonghui]

Which jobs are failing:
unit test
Which test(s) are failing:
make test
Since when has it been failing:
make test
Reason for failure:
when I add a unit test. Has nothing to do with the following path

[root@centos-kubeedge kubeedge]# make test
hack/make-rules/clean.sh
hack/make-rules/test.sh 
running tests cases 
can't load package: named files must be .go files: ./cloud/pkg/cloudhub/common/model
make: *** [test] Error 1

Anything else we need to know:
I find the the reason in hack/lib/golang.sh kubeedge::golang::get_keadm_test_dirs()
when I try to perform this step, not only get the directory, but also get the go file

[root@centos-kubeedge kubeedge]# find -L ./keadm \
    -name '*_test.go' -print | xargs -0n1 dirname | uniq
./keadm/cmd/keadm/app/cmd/debug/collect_test.go
./keadm/cmd/keadm/app/cmd/util

[daixiang0]

The issue title is so confused util i see the details.

I think it is not a failing-test, it is related to how you add a test case or test file indeed.

So, you may fille how you add test case/file, rather than writing make test in each description.

[shenkonghui]

The issue title is so confused util i see the details.

I think it is not a failing-test, it is related to how you add a test case or test file indeed.

So, you shoulmay fille how you add test case/file, rather than writing make test in each description.ok I only add

ok, I only add one unit test, in ./keadm/cmd/keadm/app/cmd/debug/collect_test.go

package debug

import (
	types1 "github.com/kubeedge/kubeedge/keadm/cmd/keadm/app/cmd/common"
	"testing"
)

func TestVerificationParameters(t *testing.T) {
...
}

when I make test it is failed, i try to remove this unit test. it is successful

I print ${KUBEEDGE_ALL_TESTCASES[@]} in kubeedge::golang::run_test, and find this unit test can not get dir and get go file.

[root@centos-kubeedge kubeedge]# make test
hack/make-rules/clean.sh
hack/make-rules/test.sh 
running tests cases 
./cloud/pkg/cloudhub/common/model ./cloud/pkg/edgecontroller/manager ./edge/pkg/devicetwin ./edge/pkg/devicetwin/dtclient ./edge/pkg/devicetwin/dtcommon ./edge/pkg/devicetwin/dtcontext ./edge/pkg/devicetwin/dtmanager ./edge/pkg/devicetwin/dtmodule ./edge/pkg/devicetwin/dttype ./edge/pkg/devicetwin ./edge/pkg/edgehub/clients/wsclient ./edge/pkg/edgehub/common/http ./edge/pkg/edgehub ./edge/pkg/eventbus/common/util ./edge/pkg/metamanager/dao ./edge/pkg/metamanager ./edge/pkg/servicebus/util ./keadm/cmd/keadm/app/cmd/debug/collect_test.go
can't load package: named files must be .go files: ./cloud/pkg/cloudhub/common/model
make: *** [test] Error 1

Finally positioned cmd find -L ./keadm \ -name '*_test.go' -print | xargs -0n1 dirname | uniq in kubeedge::golang::get_keadm_test_dirs()
I am not sure about the usage of xarg -0

[shenkonghui]

Try to modify it and try it, no -0 is normal, I’m not sure why added -0

[root@centos-kubeedge kubeedge]# find -L ./keadm -name '*_test.go'  | xargs -0  dirname
./keadm/cmd/keadm/app/cmd/debug/collect_test.go
./keadm/cmd/keadm/app/cmd/util
[root@centos-kubeedge kubeedge]# find -L ./keadm -name '*_test.go'  | xargs -0  
./keadm/cmd/keadm/app/cmd/debug/collect_test.go
./keadm/cmd/keadm/app/cmd/util/common_test.go

[root@centos-kubeedge kubeedge]# find -L ./keadm -name '*_test.go'  | xargs dirname
./keadm/cmd/keadm/app/cmd/debug
./keadm/cmd/keadm/app/cmd/util

[fisherxu]

I think print0 | xargs -0n1 or print | xargs -n1 are all fine. @shenkonghui