Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Navigation #142

Closed
CristhianF7 opened this issue Mar 14, 2023 · 2 comments · Fixed by #143
Closed

Responsive Navigation #142

CristhianF7 opened this issue Mar 14, 2023 · 2 comments · Fixed by #143
Assignees
Labels
enhancement New feature or request

Comments

@CristhianF7
Copy link
Contributor

CristhianF7 commented Mar 14, 2023

Problem

We want to refactor the navigation component, the current implementation was made to receive props but We'd prefer to use native CSS media queries rather than javascript screen listeners.

Acceptance Criteria

  • Navigation should be responsive
  • Adjust the version because is tied to the desktop version
  • Use CSS media queries with styled-media-query
  • Mobile first

Implementation Example

Use theme/media/index.ts in the style component

export const StyledComponent = styled.div`
  // mobile styles
  width: 614px;


  ${media.greaterThan('md')`
    // desktop styles
    width: 790px;
  `};
`;

Result

< 1028px

Screenshot 2023-03-14 at 9 31 36 AM

> 1028px

Screenshot 2023-03-14 at 9 38 03 AM

@D-B-Hawk
Copy link
Collaborator

Hey @CristhianF7. I would love to take care of this issue for you. I will reach out for any questions i have.

@fharper
Copy link
Member

fharper commented Mar 15, 2023

@D-B-Hawk: that's awesome, thanks for contributing.

Feel free to ask any questions here, or on our Slack community in #helpind-hands for anything kubefirst related or #contributors for specifics about this contribution (or contributing to kubefirst overall).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants