Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config call to Internal API #45

Closed
CristhianF7 opened this issue Nov 7, 2022 · 0 comments · Fixed by #47
Closed

Remove config call to Internal API #45

CristhianF7 opened this issue Nov 7, 2022 · 0 comments · Fixed by #47

Comments

@CristhianF7
Copy link
Contributor

We are not supporting the static release and the internal API anymore. We only want to read config values via Environment Variables.

  • Delete internal api from the store. src/store.ts

  • Delete internal api src/api/internalApi.ts

  • Refactor the action to read env variables from the runtime values window.__env__

  • Create a reducer function to set configs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: api and url transform kubefirst/console
1 participant
@CristhianF7