Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Fix bug in predict in examples. #335

Merged
merged 19 commits into from Aug 26, 2019
Merged

Fix bug in predict in examples. #335

merged 19 commits into from Aug 26, 2019

Conversation

abcdefgs0324
Copy link
Member

@abcdefgs0324 abcdefgs0324 commented Aug 3, 2019 •
edited by jlewi

What this PR does / why we need it:
Fix bugs in the function predict in examples

Which issue(s) this PR fixes:
Fixes #258

/assign @jlewi
/assign @zhenghuiwang

This change is Reviewable

@abcdefgs0324
Copy link
Member Author

abcdefgs0324 commented Aug 3, 2019 •
edited

Fix #202
Install dependencies before running examples

@abcdefgs0324
Copy link
Member Author

/retest

1 similar comment
@abcdefgs0324
Copy link
Member Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Aug 4, 2019

/lgtm
/approve

Thanks for the bug fix!

@jinchihe
Copy link
Member

jinchihe commented Aug 5, 2019

/retest

This was referenced Aug 5, 2019
Closed
Merged
@abhi-g
Copy link
Member

abhi-g commented Aug 5, 2019

/test kubeflow-fairing-presubmit

@abhi-g abhi-g closed this Aug 5, 2019
@abhi-g abhi-g reopened this Aug 5, 2019
@abhi-g
Copy link
Member

abhi-g commented Aug 5, 2019

@abcdefgs0324 please resolve integration test failure

@abhi-g abhi-g assigned abcdefgs0324 and unassigned jlewi and zhenghuiwang Aug 5, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 5, 2019
@jinchihe
Copy link
Member

jinchihe commented Aug 6, 2019

@abcdefgs0324 Pls rebase, the integration test problem should have been fixed in #337 thanks.

jinchihe
jinchihe reviewed Aug 6, 2019
View reviewed changes
Dockerfile.test Outdated Show resolved Hide resolved
@abcdefgs0324
Copy link
Member Author

/retest

@abcdefgs0324
Copy link
Member Author

@jinchihe Solved finally. Thanks for your help!

@jinchihe
Copy link
Member

jinchihe commented Aug 6, 2019

@abcdefgs0324 Thank you for your persistence!

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 14, 2019
@karthikv2k
Copy link
Contributor

/retest

@jinchihe
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5325a19 into kubeflow:master Aug 26, 2019
@abcdefgs0324 abcdefgs0324 deleted the ex-predict branch August 26, 2019 17:20
@fenglixa fenglixa mentioned this pull request Dec 19, 2019
Merged
@jinchihe jinchihe mentioned this pull request Jun 19, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karthikv2k karthikv2k karthikv2k left review comments

@abhi-g abhi-g abhi-g left review comments

@jinchihe jinchihe jinchihe left review comments

Assignees

@abcdefgs0324 abcdefgs0324

@jinchihe jinchihe

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in predict in the xgboost example?
7 participants
@abcdefgs0324 @jlewi @jinchihe @abhi-g @karthikv2k @k8s-ci-robot @zhenghuiwang