Add annotations param to TfJob

[dalfos]

What this PR does / why we need it:
Add annotations param to TfJob for ability to pass it to Job.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

---

This change is 

[k8s-ci-robot]

Hi @dalfos. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jinchihe]

/ok-to-test

[jinchihe]

Hey @dalfos
Could you please fix the pylint error in kubeflow/fairing/deployers/tfjob/tfjob.py?

INFO|2019-10-25T23:48:14|util.py:71| ************* Module kubeflow.fairing.deployers.tfjob.tfjob
INFO|2019-10-25T23:48:14|util.py:71| C: 32, 0: Line too long (114/100) (line-too-long)

[dalfos]

/retest

[dalfos]

Hi @jinchihe where can I see error in test process?

[jinchihe]

Error below. Should be caused by test env.

Step #2: Fetching cluster endpoint and auth data.
Step #2: ERROR: (gcloud.container.clusters.get-credentials) ResponseError: code=404, message=Not found: projects/kubeflow-ci/zones/us-cen
tral1-a/clusters/kubeflow-ci-fairing.
Step #2: No cluster named 'kubeflow-ci-fairing' in kubeflow-ci.
Finished Step #2
ERROR
ERROR: build step 2 "gcr.io/kubeflow-ci/fairing-test:latest" failed: exit status 1

/retest

[jinchihe]

@dalfos The problem may can be work around by rebasing. Could you please rebase and trigger new CI testing? Thanks.

[dalfos]

/retest

[jinchihe]

@dalfos Seems the errors are caused by testing env problem, may be resolved later. thanks.

[jinchihe]

/retest

[jinchihe]

/retest

[jinchihe]

/test kubeflow-fairing-presubmit

[jinchihe]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jinchihe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jinchihe]

/retest

[abhi-g]

/hold

[abhi-g]

/test kubeflow-fairing-presubmit

[abhi-g]

/hold cancel

[abhi-g]

/test kubeflow-fairing-presubmit

[abhi-g]

/retest

[abhi-g]

/test kubeflow-fairing-presubmit

[abhi-g]

/test kubeflow-fairing-presubmit

[abhi-g]

/retest

[abhi-g]

/test kubeflow-fairing-presubmit

[abhi-g]

/retest

[abhi-g]

@dalfos Can you please merge upstream/master to pull in test fixes

[dalfos]

@dalfos Can you please merge upstream/master to pull in test fixes

my fork's master already in sync with upstream

[abhi-g]

Hmm. I pushed a test fix yesterday. If you can rebase your PR on the new upstream/master it will run CI with the updated test.

…

On Sat, Nov 2, 2019 at 10:39 AM Andrey Petrov ***@***.***> wrote: @dalfos <https://github.com/dalfos> Can you please merge upstream/master to pull in test fixes my fork's master already in sync with upstream — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#406?email_source=notifications&email_token=ACZ2UZVKUQERSBIJGMYDJJDQRW3OHA5CNFSM4JFDQLUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5BE5Y#issuecomment-549065335>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZ2UZVKUBBLMNTYO7LHTDLQRW3OHANCNFSM4JFDQLUA> .

[jinchihe]

/lgtm