Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Fix problem that unable to get notebook filename on JupyterLab 3.0 #552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix problem that unable to get notebook filename on JupyterLab 3.0 #552

wants to merge 1 commit into from

Conversation

kangwoo
Copy link

@kangwoo kangwoo commented Feb 27, 2021 •
edited

What this PR does / why we need it:
The notebookapp has been changed from JupyterLab 3.0 to serverapp, so the list of servers is not returned.
So if there is a Jupiter_server module, I changed it to get the list of servers from serverapp.

Which issue(s) this PR fixes
Fixes #551

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Fixed to return notebook filename on JupyterLab 3.0

@google-cla
Copy link

google-cla bot commented Feb 27, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kangwoo
To complete the pull request process, please assign xauthulei after the PR has been reviewed.
You can assign the PR to them by writing /assign @xauthulei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kangwoo
Copy link
Author

kangwoo commented Feb 28, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Feb 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jinchihe jinchihe Awaiting requested review from jinchihe

@pugangxa pugangxa Awaiting requested review from pugangxa

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to get notebook filename on JupyterLab 3.0
2 participants
@kangwoo @k8s-ci-robot