Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about KatibConfig API #2186

Closed
tenzen-y opened this issue Aug 1, 2023 · 4 comments · Fixed by kubeflow/website#3665
Closed

Update documentation about KatibConfig API #2186

tenzen-y opened this issue Aug 1, 2023 · 4 comments · Fixed by kubeflow/website#3665

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Aug 1, 2023

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Because we improve the KatibConfig In #2176, we need to update the docs about katib-config.

https://www.kubeflow.org/docs/components/katib/katib-config/

Also, updating the Debveloper Guide because we introduced Golang better way to the Katib since #2176.

  • Using go-cmp instead of reflect would be more useful in the test since avoiding eyeball grep 👀
  • Defining test cases as maps instead of slices would be more reasonable since we can avoid depending on the running order.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@tenzen-y
Copy link
Member Author

/assign

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

/remove lifecycle stale

@tenzen-y
Copy link
Member Author

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants