Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Add ownerReferences to resources #490

Closed
wants to merge 1 commit into from
Closed

Add ownerReferences to resources #490

wants to merge 1 commit into from

Conversation

VaishnaviHire
Copy link
Contributor

@VaishnaviHire VaishnaviHire commented Mar 17, 2021 •
edited
Loading

Closes #460
This commit is responsible for following changes:

  • Adds owner references to all the resources in the manifest repo.
  • It also removes the kfctl.kubeflow.io/kfdef-instance: <kfdef-name>.<kfdef-namespace>
    annotation, since its no longer required. The owner references field now indicates that
    resources are owned by KfDef instance.

Ref PR: #271

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VaishnaviHire
To complete the pull request process, please assign yanniszark after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aws-kf-ci-bot
Copy link

Hi @VaishnaviHire. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crobby
Copy link
Member

crobby commented Mar 17, 2021

/ok-to-test

@VaishnaviHire
Add ownerReferences to resources
bad886f 
This commit adds owner refernces to all the resources in the manifest repo.
It also removes the 'kfctl.kubeflow.io/kfdef-instance: <kfdef-name>.<kfdef-namespace>'
annotation, since its no longer required. The owner references field now indicates that
resources are owned by KfDef instance.
@VaishnaviHire VaishnaviHire changed the title [WIP] Add ownerReferences to resources Add ownerReferences to resources Mar 18, 2021
@VaishnaviHire VaishnaviHire changed the title Add ownerReferences to resources [WIP]Add ownerReferences to resources Mar 18, 2021
@VaishnaviHire
Copy link
Contributor Author

VaishnaviHire commented Mar 23, 2021 •
edited
Loading

Adding ownerReferrences without changing the scope of the KfDef crd to Cluster is not possible from v1.20

Cross-namespace ownerreferences are disallowed and dependent objects are subject to deletion. This PR needs to be revisited, once the scope of KfDef is updated.

@VaishnaviHire VaishnaviHire changed the title [WIP]Add ownerReferences to resources Add ownerReferences to resources Mar 25, 2021
@VaishnaviHire
Copy link
Contributor Author

/hold

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adrian555 adrian555 Awaiting requested review from adrian555

@pdmack pdmack Awaiting requested review from pdmack

Assignees
No one assigned
Labels
do-not-merge/hold ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ownerreferences no longer added to resources deployed through operator
4 participants
@VaishnaviHire @google-oss-robot @aws-kf-ci-bot @crobby