Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Istio 1.0 #1309

Closed
lluunn opened this issue Aug 3, 2018 · 5 comments
Closed

Use Istio 1.0 #1309

lluunn opened this issue Aug 3, 2018 · 5 comments

Comments

@lluunn
Copy link
Contributor

lluunn commented Aug 3, 2018

We integrated istio for TF Serving with istio 0.7.
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/examples/prototypes/tf-serving-with-istio.jsonnet#L17
https://www.kubeflow.org/docs/guides/components/istio/

Now that istio is 1.0, we should migrate to that.

@lluunn
Copy link
Contributor Author

lluunn commented Oct 23, 2018

#1823 actually doesn't work: I set the traffic to v1:100,v2:0, but still see requests going to v2.

And the reason is that istio uses client-side proxy to route requests, but in this case the client (ambassador) service is not in istio mesh.

So I think options are:

  • add one additional hop
  • don't use ambassador

@lluunn
Copy link
Contributor Author

lluunn commented Oct 23, 2018

Another option: ambassador supports percentage traffic routing:
https://www.getambassador.io/reference/canary

@chrisheecho
Copy link

/remove-priority p1

@jlewi jlewi added this to To do in 0.4.0 via automation Oct 29, 2018
@jlewi jlewi moved this from To do to inference in 0.4.0 Oct 30, 2018
@jlewi
Copy link
Contributor

jlewi commented Nov 5, 2018

@lluunn Can you clarify the scope of this issue?

Is this issue just about changing the version of ISTIO from 0.7 to 1.0? Or is it more involved then that?

What work remains on this issue?

@lluunn
Copy link
Contributor Author

lluunn commented Nov 5, 2018

I think we can close this one and file separate issues.
My original thought was only to change Istio version from 0.7 to 1.0, which is done now.

We have #1844 for rollout.
Filed #1907 for jwt validation.

@lluunn lluunn closed this as completed Nov 5, 2018
0.4.0 automation moved this from inference to Done Nov 5, 2018
@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.4.0
  
Done
Development

No branches or pull requests

5 participants