New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kfctl.sh should not assume uuidgen is present #1415

Closed

jlewi opened this issue Aug 24, 2018 · 0 comments

Labels

area/0.3.0 priority/p1

Contributor

jlewi commented Aug 24, 2018

Right now kfctl.sh tries to use uuidgen to create a unique id
https://github.com/kubeflow/kubeflow/blob/master/scripts/util.sh#L74

This will cause a crash on a platform without uuidgen like Cloud Shell.

If uuidgen is not present we should simple fallback to an id like "unknown"

jlewi added priority/p1 area/0.3.0 labels

ankushagarwal mentioned this issue

Use bash ${RANDOM} instead of uuidgen #1418

Merged

k8s-ci-robot closed this as completed in #1418

jlewi mentioned this issue

deploy.sh should not assume uuidgen is present #2072

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment