Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small problem, Error validate kubeflow-core #1462

Closed
asdfsx opened this issue Sep 3, 2018 · 5 comments
Closed

A small problem, Error validate kubeflow-core #1462

asdfsx opened this issue Sep 3, 2018 · 5 comments
Labels
area/ksonnet Bugs related to ksonnet and prototypes kind/question

Comments

@asdfsx
Copy link

asdfsx commented Sep 3, 2018

I try to deploy kubeflow-core v0.2.4 to minikube as described below.

$ ks pkg install kubeflow/core@v0.2.4
$ ks generate kubeflow-core kubeflow-core
$ ks apply default -c kubeflow-core

The deploy successed.

but when I try to use validate, I got the following error

$ ks validate default 
...
INFO Validating deployments mykubeflow.ambassador
ERROR Error in deployments mykubeflow.ambassador: validation failure list:
spec.template.spec.containers.resources.limits.cpu in body must be of type string: "integer"
INFO Validating services mykubeflow.k8s-dashboard
...
ERROR validation failed

I solve this problem by modify kubeflow/core/ambassador.libsonnet,change the flowing line

cpu: 1,

to

cpu: "1",
@jlewi jlewi added area/ksonnet Bugs related to ksonnet and prototypes kind/question labels Sep 4, 2018
@jlewi
Copy link
Contributor

jlewi commented Sep 4, 2018

Can you provide the output of

ks version
kubectl version

Its really strange that you would hit this error but no one else seems to be hitting it.

It doesn't look like we set it differently for minikube vs. other platforms
https://github.com/kubeflow/kubeflow/blob/v0.2-branch/kubeflow/core/ambassador.libsonnet#L199

It also looks like the values are the same for 0.2 and 0.3
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/prototypes/ambassador.jsonnet#L237

/cc @abhi-g

@asdfsx
Copy link
Author

asdfsx commented Sep 7, 2018

sorry for reply too late

ks version

ksonnet version: 0.12.0
jsonnet version: v0.11.2
client-go version: kubernetes-1.10.4

kubectl version

Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.1", GitCommit:"b1b29978270dc22fecc592ac55d903350454310a", GitTreeState:"clean", BuildDate:"2018-07-18T11:37:06Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.2", GitCommit:"bb9ffb1654d4a729bb4cec18ff088eacc153c239", GitTreeState:"clean", BuildDate:"2018-08-07T23:08:19Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

maybe it's because the version of my Kubernetes version?
I use minikube to install a local cluster for testing, the k8s version right now is v1.10.0.

@jlewi
Copy link
Contributor

jlewi commented Oct 8, 2018

@asdfsx Did you every get this resolved? Sorry we left you hanging. You can always turn to kubeflow.slack.com for help if we're unresponsive on GitHub issues.

If you're still having trouble; I'd suggest trying 0.3 which we just released last week.

@asdfsx
Copy link
Author

asdfsx commented Oct 8, 2018

@jlewi Thx, I'll try the latest version, after I upgrade my cluster~

@jlewi
Copy link
Contributor

jlewi commented Oct 23, 2018

@asdfsx hopefully things are working. If not please reopen this issue or file a new one describing the latest problems.

@jlewi jlewi closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ksonnet Bugs related to ksonnet and prototypes kind/question
Projects
None yet
Development

No branches or pull requests

2 participants