Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate bootstraper from glide to dep #1520

Closed
lluunn opened this issue Sep 12, 2018 · 7 comments
Closed

migrate bootstraper from glide to dep #1520

lluunn opened this issue Sep 12, 2018 · 7 comments

Comments

@lluunn
Copy link
Contributor

lluunn commented Sep 12, 2018

I am hitting some error when building locally with glide install -v
Masterminds/glide#975

I will try to migrate to dep.
Other kubeflow repos also use dep kubeflow/training-operator#556

cc @kunmingg

@lluunn
Copy link
Contributor Author

lluunn commented Sep 14, 2018

My dep init never finished.
similar to golang/dep#1991

@r2d4
Copy link
Member

r2d4 commented Oct 12, 2018

/assign @r2d4

@kunmingg
Copy link
Contributor

@r2d4
One dependency we have on glide.lock file:
https://github.com/kubeflow/kubeflow/blob/master/bootstrap/Makefile#L22

@r2d4
Copy link
Member

r2d4 commented Oct 12, 2018

The dockerfiles look like they will need to change also

@kunmingg
Copy link
Contributor

Yeah can instead generate name from hash(Gopkg.lock)

@r2d4
Copy link
Member

r2d4 commented Jan 7, 2019

/unassign @r2d4

@kunmingg
Copy link
Contributor

kunmingg commented Jan 7, 2019

Now we use go modules

@kunmingg kunmingg closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants