Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfctl.sh delete doesn't check/change kubectl context before issuing delete #1669

Closed
jlewi opened this issue Sep 29, 2018 · 6 comments
Closed

Comments

@jlewi
Copy link
Contributor

jlewi commented Sep 29, 2018

I don't think kfctl.sh delete verifies that kubectl is pointing at the right cluster before it issues a delete.

We should add a check and verify that we are pointing at the same cluster as the ksonnet app before deleting the namespace.

Here's some code to try to do that in bash.
https://github.com/kubeflow/testing/blob/master/deployment/redeploy_app.sh#L84

@chrisheecho
Copy link

/priority p0

@chrisheecho
Copy link

Eng:Want PM:Need

@chrisheecho
Copy link

/remove-priority p1

@chrisheecho
Copy link

/remove-priority p0
/priority p1

@jlewi jlewi added this to To do in 0.4.0 via automation Nov 5, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Nov 5, 2018

I'll leave this as P1 for now but it likely won't make it unless someone steps up take this.

It might also be easier to implement this as part of turning kfctl.sh into a kfctl go binary.

@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Nov 26, 2018

Downgrading to P2.

Since we plan on switching to a cli #1419 I think it makes sense to invest in that and then fix it in the CLI rather than updating kfctl.sh.

@jlewi jlewi added this to Deploy Kubeflow in 0.5.0 Jan 6, 2019
0.4.0 automation moved this from To do to Done Jan 19, 2019
0.5.0 automation moved this from Deploy Kubeflow to Done Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.4.0
  
Done
0.5.0
  
Done
Development

No branches or pull requests

5 participants