Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.3.0-rc.1] Only TF 1.8 CPU shows up in the list of prepopulated Jupyter images #1671

Closed
jlewi opened this issue Sep 30, 2018 · 5 comments
Closed
Assignees
Labels

Comments

@jlewi
Copy link
Contributor

jlewi commented Sep 30, 2018

With v0.3.0-rc.1 in Jupyter I only see TF 1.8 in the list of prepropulated Jupyter images

screenshot from 2018-09-29 17-30-53

/cc @pdmack

Related to #1541 0.3 release

@jlewi jlewi added priority/p1 area/jupyter Issues related to Jupyter area/0.3.0 labels Sep 30, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Sep 30, 2018

There's a list of images in the HTML in kubeform_spawner.py

 <table style="width: 100%;">
        <tr>
            <td style="width: 30%;"><label for='image'>Image</label></td>
            <td style="width: 70%;"><input value="{0}/{1}/tensorflow-1.8.0-notebook-cpu:v0.3.0" list="image" name="image" placeholder='repo/image:tag' style="width: 100%;">
            <datalist id="image">
              <option value="{0}/{1}/tensorflow-1.4.1-notebook-cpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.4.1-notebook-gpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.5.1-notebook-cpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.5.1-notebook-gpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.6.0-notebook-cpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.6.0-notebook-gpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.7.0-notebook-cpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.7.0-notebook-gpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.8.0-notebook-cpu:v0.3.0">
              <option value="{0}/{1}/tensorflow-1.8.0-notebook-gpu:v0.3.0">
            </datalist>
            </td>
        </tr>
        </table>

But it looks like they aren't showing up; only the default image is.

@tlkh
Copy link

tlkh commented Sep 30, 2018

@jlewi I believe this is expected behavior for the HTML5 form elements (datalist) and I have verified it.

If you delete the contents of the field by deleting the text or changing the html to <input value="" list="image" name="image" placeholder='repo/image:tag' style="width: 100%;">, the dropdown works as expected except in Safari, where that element is not supported.

I've been thinking about how we can improve the dropdown but I have no real suggestions. Using Bootstrap <select> gives much better UX but no ability to enter a custom value. I am working on an implementation that combines <select> with a javascript implementation that will throw up a input field when an "other" is selected, but I've been busy with other stuff as of late so it might take a few more days.

Here's a screenshot of the exact same form on a fresh deployment:

screenshot 2018-09-30 at 10 39 56 pm

Side note:

I'm working on improvements to the Spawner UX for my own deployment for University use, and would like to contribute back some baseline improvements, but seems like there's also a seperate development track happening (see pull#1551 and @pdmack reply )

I would be interested to find out more about what's the plan!

@jlewi
Copy link
Contributor Author

jlewi commented Oct 1, 2018

@tlkh Thanks.

You can see #1630 and #34 for plans about improving the Jupyter UX and potentially getting rid of JupyterHub.

@richardsliu richardsliu self-assigned this Oct 1, 2018
@richardsliu
Copy link
Contributor

For v0.3 release let's just fix the HTML. For the future plan we can continue the discussion in #1630 .

@pdmack
Copy link
Member

pdmack commented Oct 1, 2018

except in Safari, where that element is not supported

Yeah, we knew that exception from the start. Safari is woefully behind on some HTML5 elements. Felt it was an acceptable exclusion given all the other browsers available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants