Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Update credentials filename #1715

Closed
texasmichelle opened this issue Oct 5, 2018 · 4 comments
Closed

[GCP] Update credentials filename #1715

texasmichelle opened this issue Oct 5, 2018 · 4 comments

Comments

@texasmichelle
Copy link
Member

TF-serving sets the value of GOOGLE_APPLICATION_CREDENTIALS to the contents of key.json, which is incompatible with the secret as setup by the deploy script (user-gcp-sa.json). This needs to be updated to match the filename used by the automated deploy.

@jlewi
Copy link
Contributor

jlewi commented Oct 5, 2018

/assign @lluunn

@sarahmaddox
Copy link
Contributor

Thanks @texasmichelle!
@jlewi This fix is blocking the GKE end-to-end guide (website PR #151). Please can we apply the fix to version 0.2.x as well as 0.3, as I'd like to move forward with the publication of the guide as soon as possible.

@texasmichelle
Copy link
Member Author

I second @sarahmaddox's request to apply the patch to 0.2

@texasmichelle
Copy link
Member Author

#1716 addresses this issue.

Shouldn't there be a bot that relates the PR to the issue? Is that a GitHub feature or repo-specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants