Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksonnet env should override params #1924

Closed
kkasravi opened this issue Nov 7, 2018 · 2 comments · Fixed by #1939
Closed

ksonnet env should override params #1924

kkasravi opened this issue Nov 7, 2018 · 2 comments · Fixed by #1939
Assignees

Comments

@kkasravi
Copy link
Contributor

kkasravi commented Nov 7, 2018

currently many libsonnet files have the following

    local params = _env + _params,

however this should be switched to

    local params = _params + _env,

so that env values override param values

@kkasravi
Copy link
Contributor Author

kkasravi commented Nov 7, 2018

/assign @kkasravi

@jlewi
Copy link
Contributor

jlewi commented Nov 12, 2018

@kkasravi Can you explain the issue? Its not clear to my why env should override parameters? I would actually not expect env to contain parameters that would also be defined in params. So I wouldn't expect the order to matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants