Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pipelines SDK in Jupyter images #1968

Closed
jlewi opened this issue Nov 19, 2018 · 7 comments
Closed

Install pipelines SDK in Jupyter images #1968

jlewi opened this issue Nov 19, 2018 · 7 comments
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Nov 19, 2018

We should install the pipelines SDK in our Jupyter images so that pipelines can be used.

/assign @qimingj

@qimingj
Copy link

qimingj commented Nov 27, 2018

Basically we need to install KFP SDK on all images (probably https://github.com/kubeflow/kubeflow/tree/76107ff3aa7f9fde6fd7f15f2ec0a69a35874efa/components/tensorflow-notebook-image).

We are finalizing a few things in SDK and I will cut a new release later this week or early next week. Then we can start the integration.

What's the release cadence of these images?

@IronPan
Copy link
Member

IronPan commented Nov 28, 2018

@jlewi could you confirm this the right place to pip install the DSL?
https://github.com/kubeflow/kubeflow/blob/76107ff3aa7f9fde6fd7f15f2ec0a69a35874efa/components/tensorflow-notebook-image/Dockerfile

The SDK release is currently part of pipeline deployment. So the release process would be

  1. cut a pipeline release 2. update the jupyter dockerfile and ks registry 3. cut a kubeflow release

does that sounds right?

@abhi-g
Copy link
Member

abhi-g commented Nov 28, 2018

@qimingj we can cherry pick into the v0.3.4 patch release

@kunmingg
Copy link
Contributor

@IronPan
here defines available images when start new notebook.
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/jupyter/ui/default/config.yaml
Can edit it once post-submit of #2008 is done

@IronPan
Copy link
Member

IronPan commented Nov 28, 2018

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Nov 28, 2018

I saw that the new notebook images are created with tag v-base-b5bfe47-920
Just wait for the new release. Feel free to close this issue

@jlewi jlewi closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants