Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap golang modules #2022

Closed
kkasravi opened this issue Nov 30, 2018 · 5 comments · Fixed by #2090
Closed

bootstrap golang modules #2022

kkasravi opened this issue Nov 30, 2018 · 5 comments · Fixed by #2090
Assignees
@kkasravi
Labels
area/0.5.0
Projects
0.5.0

Comments

@kkasravi
Copy link
Contributor

kkasravi commented Nov 30, 2018 •
edited

  • Move from glide to go modules (golang 1.11.2)
  • Define a multistage build docker file (move Dockerfile.build into Dockerfile) that uses the gomodule cache
  • Remove unused script start.sh
  • Upgrade debug.sh, dlv.sh to use go modules
  • Upgrade kubectl to v1.12.2
  • Upgrade ksonnet to v0.13.1
@kkasravi kkasravi mentioned this issue Nov 30, 2018
Closed
@kkasravi
Copy link
Contributor Author

/assign @kkasravi

@kunmingg kunmingg mentioned this issue Nov 30, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented Dec 3, 2018

Is this an issue a duplicate of #2024?

It seems like most of the discussion to figure out next steps is happening in #2024?

@kkasravi kkasravi mentioned this issue Dec 4, 2018
Closed
@kunmingg
Copy link
Contributor

kunmingg commented Dec 4, 2018

@kkasravi
Seems like ks module is more of a components instance than components prototype.
How can we make ks module reusable for all users that might have various parameter sets?

@kkasravi
Copy link
Contributor Author

kkasravi commented Dec 5, 2018

@kunmingg

Could I ask you to post your question above in #2024?
I'll answer it there so we're consolidating all design questions in that issue.
I'll rename this to 'ksonnet module migration'.
This issue/PR will reference the actual implementation.

@kkasravi kkasravi changed the title Support composability of ksonnet packages and components via the kubeflow client api ksonnet module migration Dec 5, 2018
@kunmingg
Copy link
Contributor

kunmingg commented Dec 5, 2018

@kkasravi
done, thanks!

@kkasravi kkasravi changed the title ksonnet module migration bootstrap golang modules and preliminary kfctl Application type definition Dec 14, 2018
@kkasravi kkasravi mentioned this issue Dec 14, 2018
Merged
6 tasks
@kkasravi kkasravi changed the title bootstrap golang modules and preliminary kfctl Application type definition bootstrap golang modules Dec 14, 2018
@kkasravi kkasravi mentioned this issue Dec 14, 2018
Closed
3 tasks
@jlewi jlewi added this to Done in 0.5.0 Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkasravi kkasravi

Labels
area/0.5.0
Projects
No open projects
0.5.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes 'bootstrap golang modules' kkasravi/kubeflow
3 participants
@kkasravi @jlewi @kunmingg