Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the kubeflow project image location #2226

Closed
chenzhiwei opened this issue Jan 7, 2019 · 10 comments
Closed

Unify the kubeflow project image location #2226

chenzhiwei opened this issue Jan 7, 2019 · 10 comments

Comments

@chenzhiwei
Copy link

chenzhiwei commented Jan 7, 2019

Kubeflow project includes many docker images, but they are in different locations.

Can we put them into a unified location?

And we can also use same logic to build and publish images, such as Makefile.

This will make the images are easy to maintain.

There are following works and I am working on first one:

  1. Unify the image dockerfiles

    Makes the dockerfiles can build both amd64 and ppc64le docker images.

  2. Unify the image build logics

    • make build-image to build image
    • make build-image-ppc64le to build ppc64le image
    • make push-image to push image to registry
    • make mirror-image to mirror image
  3. Unify the image locations

@jlewi
Copy link
Contributor

jlewi commented Jan 7, 2019

Thanks for helping out.

Can you elaborate on what you are working on? Which Dockerfiles are you planning on refactoring?

@chenzhiwei
Copy link
Author

@jlewi I just updated the issue to include the related PRs, and will also include new PRs when available. My plan is first to make all docker images are buildable by makefile, then unify the location. There are two alternatives: docker.io/kubeflow and gcr.io/kubeflow-images-public.

@jlewi
Copy link
Contributor

jlewi commented Jan 10, 2019

I'd like to support both docker and gcr.io and possibly others. It would be great to setup the ability to automatically mirror our docker images across registries.

There's been a long standing issue to fix this. see #211. Would love to find someone willing to drive that.

@gyliu513
Copy link
Member

gyliu513 commented Mar 7, 2019

@dreamryx

@dreamryx
Copy link

I will continue the work. The dockerfiles of related image are list as below:

image/dockerfile repo
centraldashboard kubeflow
ambassador ambassador-envoy
jupyterhub-k8s kubeflow
vizier-core katib
vizier-core-rest katib
studyjobcontroller katib
metricscollector katib
suggestion-random katib
suggestion-grid katib
suggestion-hyperband katib
suggestion-bayesianoptimization katib
katib-ui katib
metacontroller kubeflow
pytorch-operator pytorch-operator

@stale
Copy link

stale bot commented Jun 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jun 9, 2019
@gyliu513
Copy link
Member

we are still working for this.

@jlewi
Copy link
Contributor

jlewi commented Aug 10, 2019

@gyliu513 What are the next steps?

@jlewi jlewi removed this from To Do in Needs Triage Aug 10, 2019
@gyliu513
Copy link
Member

@jlewi we are now working for multi-arch support at #2633 , and will resume this after #2633 finished, hope it is OK.

@jlewi jlewi added this to To Do in Needs Triage Sep 9, 2019
@jlewi jlewi removed this from To Do in Needs Triage Sep 9, 2019
@stale
Copy link

stale bot commented Nov 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants