Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go based implementation of the profiles custom resource? #2270

Closed
jlewi opened this issue Jan 14, 2019 · 2 comments
Closed

Go based implementation of the profiles custom resource? #2270

jlewi opened this issue Jan 14, 2019 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 14, 2019

Currently the profiles custom controller is implemented using metacontroller with the sync function implemented in jsonnet.

Should we switch to a go based implementation? I think the primary reason for switching to go would be that it has a much higher ceiling; i.e. if we want to do more complicated things either; we won't find ourselves limited by jsonnet. It should also be easier to write unittests.

@kkasravi WDYT

@jlewi jlewi added this to New in 0.5.0 via automation Jan 14, 2019
@jlewi jlewi moved this from New to Multi-user kubeflow in 0.5.0 Jan 14, 2019
@kkasravi
Copy link
Contributor

yes, Profiles is a good choice because we may need to look up the user as part of creating the Profile to see if the user is in the set of people that can create a Profile. Right now we don't have this concept - any valid IAM user or ServiceAccount will work. Also we could probably reduce the 2 controllers we have (profiles-controller, permissions-controller) to just one.

@lluunn
Copy link
Contributor

lluunn commented Feb 5, 2019

Agree that we just need one controller, profile, and it will create the namespace+role+rolebinding.

@kkasravi I can take on this you haven't started?

@lluunn lluunn self-assigned this Feb 26, 2019
0.5.0 automation moved this from Multi-user kubeflow to Done Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.5.0
  
Done
Development

No branches or pull requests

3 participants