Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate test_flake8.py into CI system #2388

Closed
jlewi opened this issue Feb 4, 2019 · 5 comments
Closed

Integrate test_flake8.py into CI system #2388

jlewi opened this issue Feb 4, 2019 · 5 comments
Assignees
@bikramnehra
Labels
area/testing good first issue help wanted priority/p2

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 4, 2019

#2247 added a test for flakes related to python3.

We should integrate this into our CI system.

To do that we could just add it to the unittests workflow.

We just need to add a step here:

kubeflow/testing/workflows/components/unit_tests.jsonnet

Line 109 in 01519e7

{

/cc @cclauss
@jlewi jlewi mentioned this issue Feb 4, 2019
Merged
@bikramnehra
Copy link
Member

@jlewi you can assign this to me

@bikramnehra bikramnehra mentioned this issue Feb 5, 2019
Merged
@bikramnehra
Copy link
Member

created #2403

@bikramnehra
Copy link
Member

/assign

@bikramnehra
Copy link
Member

#2403 merged.

This can be closed now

@lluunn
Copy link
Contributor

lluunn commented Mar 14, 2019

thanks!

@lluunn lluunn closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikramnehra bikramnehra

Labels
area/testing good first issue help wanted priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @bikramnehra @lluunn