Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomize support to kfctl #2445

Closed
jlewi opened this issue Feb 11, 2019 · 4 comments · Fixed by #2971
Closed

Add kustomize support to kfctl #2445

jlewi opened this issue Feb 11, 2019 · 4 comments · Fixed by #2971

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 11, 2019

Doc:
http://bit.ly/2RwMP8q

The immediate need is kfctl(go) needs to support installing ISTIO see #2052.
We currently install ISTIO using its YAML manifest.
We could either add support to kfctl for installing YAML or we could just

  1. Add support for kustomize
  2. Turn YAML manifests into kustomize packages by adding kustomize files

To add support for kustomize we need to implement the KfApp interface for kustomize
https://github.com/kubeflow/kubeflow/tree/master/bootstrap/cmd/kfctl#kfapp-interface

See also #2351

@jlewi jlewi added this to New in 0.5.0 via automation Feb 11, 2019
@lluunn
Copy link
Contributor

lluunn commented Feb 11, 2019

cc

@jlewi jlewi moved this from New to Deploy Kubeflow in 0.5.0 Feb 12, 2019
@kkasravi
Copy link
Contributor

/assign @kkasravi

@jlewi jlewi moved this from Deploy Kubeflow to kfctl supports kustomize in 0.5.0 Mar 10, 2019
@jlewi jlewi added this to New in 0.6.0 via automation Mar 23, 2019
@jlewi jlewi removed this from kfctl supports kustomize in 0.5.0 Mar 23, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Apr 8, 2019

@kkasravi I know you've been working on this. Any update on what the remaining blockers are?

@kkasravi
Copy link
Contributor

kkasravi commented Apr 9, 2019

@jlewi

@kkasravi I know you've been working on this. Any update on what the remaining blockers are?

  • Delete isn't implemented but I will leverage labels that kustomize applies.
  • A few remaining .jsonnet conversions for GCP (see below)
    • basic-auth-ingress.jsonnet
    • metric-collector.jsonnet
    • prometheus.jsonnet

deploy to GCP works using the following

kfctl init ~/kubeflow --skip-init-gcp-project --platform gcp --project constant-cubist-173123 --package-manager kustomize@pull/13
cd ~/kubeflow
kfctl generate all
kfctl apply all

I'll update the complete list here as well as the breakdown between @swiftdiaries and myself.
We can put priorities on the remaining ones if you would like.

@jlewi jlewi moved this from To do to In progress in ksonnet-turndown Apr 15, 2019
ksonnet-turndown automation moved this from In progress to Done Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.6.0
  
New
Development

Successfully merging a pull request may close this issue.

3 participants