Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling os.makedirs fails even after we have check for directory existence. #2484

Closed
ashahba opened this issue Feb 15, 2019 · 1 comment
Closed
Projects

Comments

@ashahba
Copy link
Member

ashahba commented Feb 15, 2019

Looks like there is some race condition that causes os.makedires calls to fail randomly even after we have just checked if directory exists prior to creation.
here is one example and the error is:

W
Traceback (most recent call last):
 File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
   "__main__", fname, loader, pkg_name)
 File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
   exec code in run_globals
 File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-2447-7bbe31e-5722-c39c/src/kubeflow/kubeflow/testing/test_deploy.py", line 792, in <module>
   main()
 File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-2447-7bbe31e-5722-c39c/src/kubeflow/kubeflow/testing/test_deploy.py", line 756, in main
   os.makedirs(os.path.dirname(test_log))
 File "/usr/lib/python2.7/os.py", line 157, in makedirs
   mkdir(name, mode)
OSError: [Errno 17] File exists: '/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-2447-7bbe31e-5722-c39c/output/artifacts/logs'
@jlewi jlewi changed the title Ccalling os.makedirs fails even after we have check for directory existence. Calling os.makedirs fails even after we have check for directory existence. Feb 15, 2019
@jlewi jlewi added this to New in 0.5.0 via automation Feb 15, 2019
@ashahba
Copy link
Member Author

ashahba commented Feb 19, 2019

PR was merged and this one is can be safely closed now.

@ashahba ashahba closed this as completed Feb 19, 2019
0.5.0 automation moved this from New to Done Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.5.0
  
Done
Development

No branches or pull requests

2 participants