Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presubmit error: ImportError: cannot import name tf_job_client #2574

Closed
lluunn opened this issue Feb 27, 2019 · 8 comments
Closed

presubmit error: ImportError: cannot import name tf_job_client #2574

lluunn opened this issue Feb 27, 2019 · 8 comments
Assignees
@zabbasi
Labels
priority/p1
Projects
0.5.0

Comments

@lluunn
Copy link
Contributor

lluunn commented Feb 27, 2019

from #2404

from py import tf_job_client
ImportError: cannot import name tf_job_client

Seems related to kubeflow/training-operator#945?
@lluunn
Copy link
Contributor Author

lluunn commented Feb 27, 2019

seems temporary fix by #2555

@lluunn
Copy link
Contributor Author

lluunn commented Feb 27, 2019

We still need a proper fix and revert #2555
/cc @richardsliu
/assign @zabbasi

@jlewi jlewi mentioned this issue Feb 28, 2019
Merged
@jlewi
Copy link
Contributor

jlewi commented Feb 28, 2019

Is a proper fix to #2555 just editing the PYTHONPATH to include the new py directory in the tf-operator repository?

@lluunn
Copy link
Contributor Author

lluunn commented Feb 28, 2019

And also update test files' import

@lluunn
Copy link
Contributor Author

lluunn commented Feb 28, 2019

I still see presubmit failing with

from py import tf_job_client
ImportError: cannot import name tf_job_client

@lluunn
Copy link
Contributor Author

lluunn commented Feb 28, 2019

maybe this line needs change:

kubeflow/testing/workflows/components/kfctl_test.jsonnet

Line 177 in f5dc021

value: "kubeflow/tf-operator@HEAD;kubeflow/testing@HEAD",

@lluunn lluunn mentioned this issue Feb 28, 2019
Closed
@jlewi jlewi added this to New in 0.5.0 via automation Mar 4, 2019
@jlewi
Copy link
Contributor

jlewi commented Mar 4, 2019

@zabbasi Is this fixed?

@lluunn
Copy link
Contributor Author

lluunn commented Mar 4, 2019

This is fixed

@lluunn lluunn closed this as completed Mar 4, 2019
0.5.0 automation moved this from New to Done Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zabbasi zabbasi

Labels
priority/p1
Projects
No open projects
0.5.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @zabbasi @lluunn