Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfctl go doesn't exit with non-zero exit code on failure #2699

Closed
jlewi opened this issue Mar 14, 2019 · 0 comments · Fixed by #2721
Closed

kfctl go doesn't exit with non-zero exit code on failure #2699

jlewi opened this issue Mar 14, 2019 · 0 comments · Fixed by #2721

Comments

@jlewi
Copy link
Contributor

jlewi commented Mar 14, 2019

I ran kfctl with invalid arguments so it exits with an error; but the exit code is still zero

./bin/kfctl init /tmp/kfctl_test_20190314_060750
ERRO[0000] couldn't create KfApp: invalid name kfctl_test_20190314_060750 must consist of lower case alphanumeric characters, '-' or '.',
and must start and end with an alphanumeric character 
jlewi@jlewi-carbon-glaptop:~/git_kubeflow/bootstrap$ echo $?
0

We should exit with non-zero exit code on failure.

@jlewi jlewi added this to New in 0.5.0 via automation Mar 14, 2019
@jlewi jlewi moved this from New to kfctl Go binary is ready for users in 0.5.0 Mar 15, 2019
0.5.0 automation moved this from kfctl Go binary is ready for users to Done Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.5.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant