Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab version in default images is outdated #3442

Closed
Ark-kun opened this issue Jun 11, 2019 · 6 comments
Closed

JupyterLab version in default images is outdated #3442

Ark-kun opened this issue Jun 11, 2019 · 6 comments
Assignees

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 11, 2019

It would be nice if it included this fix jupyterlab/jupyterlab#5814 for kubeflow/pipelines#252

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.81. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 20, 2019

/assign @jlewi @elikatsis

@jlewi
Copy link
Contributor

jlewi commented Aug 21, 2019

@Ark-kun Has this been released? What version of jupyter lab do you want?

We should be installing the latest version of jupyter from pip

RUN pip install --upgrade pip==19.0.1 && \

@jlewi jlewi removed this from To Do in Needs Triage Aug 26, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 3, 2019

Can you check your version using pip3 freeze?
The version in my notebook is 0.35.4 https://pypi.org/project/jupyterlab/0.35.4/ which has been released in November while the fixed version is 0.35.5 https://pypi.org/project/jupyterlab/0.35.5/

@jlewi jlewi added this to To Do in Needs Triage Sep 9, 2019
@jlewi jlewi removed this from To Do in Needs Triage Sep 9, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 12, 2019

We should be installing the latest version of jupyter from pip

Technically, that's not guaranteed
That command first installs tensorflow (which might be installing some old version of jupyterlab) and then asks to have any version of jupyterlab without --upgrade.

AFAIK, this issue is solved though.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 12, 2019

I've verified that it's fixed in KF 0.7

@Ark-kun Ark-kun closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants