Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./kfctl generate --help #3956

Closed
butuzov opened this issue Aug 20, 2019 · 4 comments
Closed

./kfctl generate --help #3956

butuzov opened this issue Aug 20, 2019 · 4 comments

Comments

@butuzov
Copy link

butuzov commented Aug 20, 2019

/kind feature

Why you need this feature:
To have a clear idea on how the tool works.

Describe the solution you'd like:
remove '--platform gcp' from help text, and replace it with "if the chosen platform is gcp"

Anything else you would like to add:
having '--platform gcp' in help text is a bit misleading, I did try to run it with (code below) before checking source code, to get a list of available options.

kfctl generate -p=minikube -V
kfctl generate -platform minikube -V
kfctl generate --platform gcp -V

While this is a command, not an option^ even if it runs as command will bring an invalid resource error.

kfctl generate platform gcp -V

Guess update command/flags description is good. Right?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jlewi jlewi added this to To Do in Needs Triage Aug 26, 2019
@kkasravi
Copy link
Contributor

/area kfctl
/priority p3

@k8s-ci-robot k8s-ci-robot added area/kfctl priority/p3 Very low priority. labels Aug 27, 2019
@kkasravi
Copy link
Contributor

we're moving to a model where --config <config_file> will replace most command args including the platform choice. See #3919 - also the config files under kubeflow/bootstrap/config are moving to the kubeflow/manifests repo.

@jlewi jlewi removed this from To Do in Needs Triage Sep 9, 2019
@stale
Copy link

stale bot commented Nov 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants