jwa(front): Auto update mount path #6875
Conversation
|
/assign @kimwnasptd |
tasos-ale
force-pushed
the
feature-auto-update-mount-path
branch
from
6a6b783
to
187b362
Compare
There was a problem hiding this comment.
Tested the image and it fixes the issue. Also, the code looks good. Small nit would be to rename volGroupPrv to prvVolGroup since that's what we do in the rest of the code as far as I'm concerned but it's not essential. Αlso, recently we switched to the term UI tests instead of e2e for Cypress tests. Thank you @tasos-ale
cc @kimwnasptd
/lgtm
Add missing generateName form control when creating the metadata form group from a PVC. Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
Extend VolumeMountComponent class and update volume's mount path when it is not dirty and name is changed. This feature affects only the data volumes and not the workspace volume. Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
tasos-ale
force-pushed
the
feature-auto-update-mount-path
branch
from
187b362
to
ed0ed5f
Compare
|
@orfeas-k I pushed the changes you mentioned. cc @kimwnasptd |
tasos-ale
requested review from
orfeas-k
and removed request for
thesuperzapper and
elikatsis
|
Thank you @tasos-ale! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix an issue in JWA's form and change the volume's mount path when the volume's name changes. This feature is already working for workspace volumes. Also, add one more e2e test for the volume's mount path.