Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Abstract driver.go configmap/secret volume and env mount into a common function. #10491

Closed
Tomcli opened this issue Feb 15, 2024 · 2 comments
Labels
lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@Tomcli
Copy link
Member

Tomcli commented Feb 15, 2024

          > > Thanks @roytman, the tests are passed now. Are you planning to refactor the two for loops for configmap mount and configmap env into functions?

Hi @Tomcli , sorry, I don't see how it can be done without changes in kubernetes_platform/proto/kubernetes_executor_config.proto and in k8s.io/api/core/v1 can we check it together?

I'm thinking more of refactoring the common pieces between configmap and secret volume mount into a common function. Since it involved some object abstraction for configmapRef/secretRef, we can defer this to a follow up PR.

/lgtm

Originally posted by @Tomcli in #10483 (comment)

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Apr 16, 2024
Copy link

github-actions bot commented May 8, 2024

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Development

No branches or pull requests

1 participant