Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Create version command requires both pipeline_id and pipeline_name #10825

Open
rchojn opened this issue May 16, 2024 · 0 comments
Open

Comments

@rchojn
Copy link

rchojn commented May 16, 2024

Environment

  • KFP version:
    2.7.0
  • KFP SDK version:
    2.0.5
  • All dependencies version:
    kfp 2.7.0
    kfp-kubernetes 1.2.0
    kfp-pipeline-spec 0.3.0
    kfp-server-api 2.0.5

Steps to reproduce

kfp pipeline create-version -n some-pipeline pipeline.yaml
Usage: kfp pipeline create-version [OPTIONS] PACKAGE_FILE
Try 'kfp pipeline create-version --help' for help.

Error: Missing option '-v' / '--pipeline-version'.

Expected result

The correct behaviour should be allowing creation of the pipeline by providing pipeline-version OR pipeline-name option.

Materials and Reference

create-version function utilize upload_pipeline_version under the hood which has potential bug:
here

Potential fix:

        if  not any([pipeline_id, pipeline_name]):
            raise ValueError('Either pipeline_id or pipeline_name is required.')

Impacted by this bug? Give it a 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant