Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample tests for all core samples #1813

Closed
gaoning777 opened this issue Aug 12, 2019 · 16 comments
Closed

Add sample tests for all core samples #1813

gaoning777 opened this issue Aug 12, 2019 · 16 comments

Comments

@gaoning777
Copy link
Contributor

No description provided.

@jessiezcc
Copy link
Contributor

@gaoning777, pls assign to whoever is helping on this project

@gaoning777
Copy link
Contributor Author

This will depend on some test infra improvement that jiaxiao is working on.

@gaoning777
Copy link
Contributor Author

adding some core sample tests: #2030

@gaoning777
Copy link
Contributor Author

adding multiple output sample test: #2109

@numerology
Copy link

Suggestion: Maybe not cover retry sample for now due to its non-deterministic behavior.

@gaoning777
Copy link
Contributor Author

Thanks Jiaxiao for the efforts.

@gaoning777
Copy link
Contributor Author

sidecar test: #2106

@gaoning777
Copy link
Contributor Author

component build sample: #2109

@gaoning777
Copy link
Contributor Author

gaoning777 commented Sep 17, 2019

There are some sample tests that require extra work:
Category 1) non-determinism. Samples such as retry is non-deterministic. There is no sample test infra support for such non-deterministic behaviors. We will run the DSL compiler against it without running the pipeline. Since retry is part of the argo support, this is sufficient for now to only test the DSL compilation.
Category 2) platform support. Samples such as preemptible_tpu_gpu requires more platform configurations, which is not supported by the sample test infra. This support is quite complex and deprioritized for now.

@gaoning777
Copy link
Contributor Author

retry: #2141

@gaoning777
Copy link
Contributor Author

artifact location: #2142

@gaoning777
Copy link
Contributor Author

Updated the assignment.

@gaoning777
Copy link
Contributor Author

preemptible vm&volume snapshot: #2149

@gaoning777
Copy link
Contributor Author

@Ark-kun any progress on the multiple output test?

@gaoning777
Copy link
Contributor Author

resource_ops sample test: #2274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants