Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] visualization of failed pipelines inaccurate after upgrading argo #5322

Closed
Bobgy opened this issue Mar 18, 2021 · 4 comments
Closed

[UI] visualization of failed pipelines inaccurate after upgrading argo #5322

Bobgy opened this issue Mar 18, 2021 · 4 comments
Assignees
Labels

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Mar 18, 2021

What steps did you take:

[A clear and concise description of what the bug is.]

What happened:

It seems there was a change that all skipped nodes in the pipeline are also added to workflow status, so they also render in KFP UI now. However, it doesn't show properly.

TODO: I'll upload a screenshot and give an example here.

What did you expect to happen:

The skipped nodes should either be hidden, or we remove the unfinished sign after the last unfinished node.

Environment:

How did you deploy Kubeflow Pipelines (KFP)?

KFP version:

KFP SDK version:

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind bug

@Bobgy Bobgy added this to Pending Triage in Kubeflow 1.3 release via automation Mar 18, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 18, 2021

/cc @zijianjoy

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 19, 2021

Example pipeline

HOST = '<redacted>'

import kfp
import kfp.components as comp


def fail():
    import sys
    println("failed")
    sys.exit(1)


def echo():
    println("hello world")


def main():
    fail_op = comp.func_to_container_op(fail)
    echo_op = comp.func_to_container_op(echo)

    @kfp.dsl.pipeline(name='fail sample')
    def fail_sample():
        fail_task = fail_op()
        echo_task = echo_op()
        echo_task.after(fail_task)

    client = kfp.Client(host=HOST)
    client.create_run_from_pipeline_func(fail_sample, {})


if __name__ == "__main__":
    main()

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 19, 2021

However, here is the pipeline visualization of the failed pipeline

image

The pipeline has two tasks, the first fails, so the second one is omitted.
What happened?
However, the already completed and failed pipeline visualization shows the last task as pending further execution.
and the echo op status is unknown.

Expected: there should be no unfinished sign after the last step. and echo op should be shown as omitted

@zijianjoy zijianjoy self-assigned this Mar 19, 2021
@Bobgy Bobgy moved this from Pending Triage to In progress in Kubeflow 1.3 release Mar 23, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 24, 2021

Fixed by #5339
@zijianjoy FYI, if you use Fixes #5322 in your PR's title. This issue will be auto closed when your PR is merged. That's best practice for keeping the issue lifecycle up-to-date.

@Bobgy Bobgy closed this as completed Mar 24, 2021
Kubeflow 1.3 release automation moved this from In progress to Done Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

3 participants