Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add PVC File Browser to Viewer CRD #5651

Closed
davidspek opened this issue May 15, 2021 · 8 comments
Closed

[feature] Add PVC File Browser to Viewer CRD #5651

davidspek opened this issue May 15, 2021 · 8 comments
Labels
area/backend kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@davidspek
Copy link
Contributor

davidspek commented May 15, 2021

Feature Area

/area backend

What feature would you like to see?

Add a PVC Viewer/File Browser spec to the Viewer controller.

What is the use case or pain point?

This feature would allow people to launch a "File Browser" pod, which allows them to easily drag and drop files into a PVC or download files and folders present in a PVC. For KFP users, this can be useful if a pipeline step produces some form of data in a PVC that the user would like to easily download. The same CR would then be used to extend the Volumes Web App with a button that allows people to start a "File Browser" pod to easily upload and download file to and from their PVCs (most likely for the PVCs used with notebook servers). I currently have built a dedicated controller for this, but given that the pipelines viewer CRD is built to be extendable I thought it would make sense to add it to an existing controller. A demo of this functionality can be seen below.

vwa-pvcviewer-demo

Is there a workaround currently?

There currently is no easy way for users to upload and download data to and from their PVCs, which is a large hurdle for people that have local data that they would like to use within their notebooks or pipelines.


Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.

@davidspek davidspek changed the title [feature] <Description> [feature] Add PVC File Browser to Viewer CRD May 15, 2021
@jtfogarty
Copy link

jtfogarty commented May 15, 2021

👍🏽
This will come in very handy for my users!!

@zulissi
Copy link

zulissi commented May 15, 2021

This would also be very helpful for us. Especially when trying to figure out which PVCs can be safely cleaned up.

@karlschriek
Copy link

Looks great! Really handy feature and very much in line with the sort of functionality our our clients are looking for. What would need happen in order to implement this?

@blairdrummond
Copy link

This approach would be very useful for us. It would also help with a related functionality; ultimately artifacts that researchers create within these notebooks will need to be extracted out and sent to a vetting team to assess possible disclosures. This strategy would make it really easy for us to build a workflow for that use-case.

@hilcj hilcj added this to Needs triage in KFP Runtime Triage via automation May 18, 2021
@ca-scribner
Copy link
Contributor

Yeah this would definitely be helpful. Having better support for this would make managing PVCs much easier, which in turn would make managing data generated by pipelines much easier. Would be great for use cases that need some mix of automation and interactivity.

@Bobgy
Copy link
Contributor

Bobgy commented May 19, 2021

Hi folks, I'm sending out a proposal for building a generic viewer, see #5681.
Curious about your thoughts there.

@zijianjoy zijianjoy moved this from Needs triage to Needs More Info in KFP Runtime Triage May 21, 2021
@stale
Copy link

stale bot commented Aug 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Aug 28, 2021
@stale
Copy link

stale bot commented Mar 3, 2022

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Mar 3, 2022
KFP Runtime Triage automation moved this from Needs More Info to Closed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
Development

No branches or pull requests

8 participants