Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Migrate code implementation to kubeflow/common fashion #282

Open
Jeffwan opened this issue Jun 16, 2020 · 3 comments
Open

Migrate code implementation to kubeflow/common fashion #282

Jeffwan opened this issue Jun 16, 2020 · 3 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Jun 16, 2020

kubeflow/common release a stable version 0.3.1 and we can migrate to use implementation of kubeflow/common.

The change will be similar to change kubeflow/training-operator#1171.

It would be better to resolve dependencies, upgrade to 0.3.1 for interfaces, and then update implementation.

Hope this can be part of 1.1 release.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.98

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@johnugeorge
Copy link
Member

I am worried if it is little late for the 1.1 release. TF-operator one too has not been tested extensively with common.

@Jeffwan
Copy link
Member Author

Jeffwan commented Jun 19, 2020

@johnugeorge Yeah, If we can not catch 1.1 release, I think we can postpone to next release. As TF and Pytorch already graduate to v1, we definitely need more test to avoid regression issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants