Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate workflow name in prow_config.yaml #72

Closed
jose5918 opened this issue Mar 20, 2018 · 1 comment
Closed

Truncate workflow name in prow_config.yaml #72

jose5918 opened this issue Mar 20, 2018 · 1 comment
Labels
priority/p2

Comments

@jose5918
Copy link
Contributor

Found that if the workflow name is too long in prow_config.yaml I get this error:

Pod "kubeflow-pytorch-operator-presubmit-pytorchjob-e2e-13-1a13f4d-3-17ac-2950311768" is invalid: metadata.labels: Invalid value: "kubeflow-pytorch-operator-presubmit-pytorchjob-e2e-13-1a13f4d-3-17ac": must be no more than 63 characters

Should probably truncate or provide a warning to to the user.
@jose5918 jose5918 mentioned this issue Mar 20, 2018
Closed
@jlewi jlewi mentioned this issue Mar 21, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented Apr 9, 2019

I believe all our workflows are properly truncating the names right now so I'm going to close this.

@jlewi jlewi closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @jose5918