Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tf-operator panic when cleanupTFJob #994

Closed
wackxu opened this issue May 10, 2019 · 4 comments · Fixed by #995
Closed

tf-operator panic when cleanupTFJob #994

wackxu opened this issue May 10, 2019 · 4 comments · Fixed by #995
Labels
kind/bug

Comments

@wackxu
Copy link
Contributor

wackxu commented May 10, 2019

tf-operator panic when clean tfjob that exceeds limit, because the CompletionTime of tfjob is nil, so we should first set CompletionTime first for the tfjob then try to clean the job.

20190510-101936(eSpace)
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@wackxu wackxu mentioned this issue May 10, 2019
Merged
@johnugeorge
Copy link
Member

Can you paste your tf job yaml here? Have you set ttl?

@gaocegege
Copy link
Member

I think #995 can fix it.

@wackxu
Copy link
Contributor Author

wackxu commented May 10, 2019

@johnugeorge Yes, I set ttl and activeDeadlineSeconds in the tfjob

@wackxu wackxu mentioned this issue May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set CompletionTime first when tfjob exceeds limit wackxu/tf-operator
3 participants
@johnugeorge @gaocegege @wackxu