/
pytorch_validation.go
92 lines (80 loc) · 3.01 KB
/
pytorch_validation.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
// Copyright 2018 The Kubeflow Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package v1
import (
"fmt"
apimachineryvalidation "k8s.io/apimachinery/pkg/api/validation"
)
func ValidateV1PyTorchJob(pytorchJob *PyTorchJob) error {
if errors := apimachineryvalidation.NameIsDNS1035Label(pytorchJob.ObjectMeta.Name, false); errors != nil {
return fmt.Errorf("PyTorchJob name is invalid: %v", errors)
}
if err := validatePyTorchReplicaSpecs(pytorchJob.Spec.PyTorchReplicaSpecs); err != nil {
return err
}
if err := validateNprocPerNode(pytorchJob); err != nil {
return err
}
return nil
}
func validateNprocPerNode(pytorchJob *PyTorchJob) error {
if pytorchJob.Spec.NprocPerNode != nil && pytorchJob.Spec.ElasticPolicy != nil && pytorchJob.Spec.ElasticPolicy.NProcPerNode != nil {
return fmt.Errorf(".spec.elasticPolicy.nProcPerNode is deprecated, use .spec.nprocPerNode instead")
}
return nil
}
func validatePyTorchReplicaSpecs(specs map[ReplicaType]*ReplicaSpec) error {
if specs == nil {
return fmt.Errorf("PyTorchJobSpec is not valid")
}
for rType, value := range specs {
if value == nil || len(value.Template.Spec.Containers) == 0 {
return fmt.Errorf("PyTorchJobSpec is not valid: containers definition expected in %v", rType)
}
// Make sure the replica type is valid.
validReplicaTypes := []ReplicaType{PyTorchJobReplicaTypeMaster, PyTorchJobReplicaTypeWorker}
isValidReplicaType := false
for _, t := range validReplicaTypes {
if t == rType {
isValidReplicaType = true
break
}
}
if !isValidReplicaType {
return fmt.Errorf("PyTorchReplicaType is %v but must be one of %v", rType, validReplicaTypes)
}
//Make sure the image is defined in the container
defaultContainerPresent := false
for _, container := range value.Template.Spec.Containers {
if container.Image == "" {
msg := fmt.Sprintf("PyTorchJobSpec is not valid: Image is undefined in the container of %v", rType)
return fmt.Errorf(msg)
}
if container.Name == PyTorchJobDefaultContainerName {
defaultContainerPresent = true
}
}
//Make sure there has at least one container named "pytorch"
if !defaultContainerPresent {
msg := fmt.Sprintf("PyTorchJobSpec is not valid: There is no container named %s in %v", PyTorchJobDefaultContainerName, rType)
return fmt.Errorf(msg)
}
if rType == PyTorchJobReplicaTypeMaster {
if value.Replicas != nil && int(*value.Replicas) != 1 {
return fmt.Errorf("PyTorchJobSpec is not valid: There must be only 1 master replica")
}
}
}
return nil
}