Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up vendor dependencies #1162

Closed
Jeffwan opened this issue May 22, 2020 · 17 comments
Closed

Clean up vendor dependencies #1162

Jeffwan opened this issue May 22, 2020 · 17 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented May 22, 2020

As we migrate from dep to go modules. There's no need to keep vendor redirectory.

however, In order to remove it, there're some prerequisite steps.

  1. Update update-codegen.sh to remove reference. Use code-generator from go mod.
  2. python-sdk generation needs to be vendor independent. Similarly, we should use kube-openapi in go pkg.
  3. Remove any vendor dependency in .travis.yaml or Dockerfile
@Jeffwan Jeffwan self-assigned this May 22, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.73
area/operator 0.77

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.73
area/operator 0.77

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@Jeffwan
Copy link
Member Author

Jeffwan commented May 22, 2020

I did similar work for PyTorch and MXNet and I will take this one.

@gaocegege
Copy link
Member

Since we cannot remove it from the .git history to reduce the repo size, can we just keep it?

@Jeffwan
Copy link
Member Author

Jeffwan commented Jun 11, 2020

@gaocegege I don't quite understand that. Do you mean the repo size won't drop after vendor clean up? I think if there's reasonable request on vendor mode, we can keep it.

@terrytangyuan
Copy link
Member

@gaocegege Well, technically it's possible to remove it from the history as well through git-filter-branch but can be dangerous. Unless there's strong reason to do that, e.g. accidentally pushed large files, we should refrain from doing so.

We can probably keep it around if really needed. Though one can always just use generate it on his own.

@gaocegege
Copy link
Member

As you all know, vendor downloading in the Chinese mainland is sometimes affected for some unknown reasons. Thus prefer to keep it to make it easy for new contributors in China.

@terrytangyuan
Copy link
Member

@gaocegege Good point. Is there any good/reliable workaround for that?

@gaocegege
Copy link
Member

From our experience, we keep the vendor in git repository and check if it is updated in CI.

@stale
Copy link

stale bot commented Sep 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Sep 17, 2020
@Jeffwan Jeffwan reopened this Oct 8, 2020
@stale stale bot removed the lifecycle/stale label Oct 8, 2020
@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 8, 2020

I agree on git-filter-branch , I think we consider to remove vendor in master, won't wipe git history. If we plan to do so, we need to be careful to only modify commits with vendor/ folder changes.

For China region, is there's a reliable GOPROXY people can use to speed up downloading?

@gaocegege
Copy link
Member

Yeah, I think so. We can remove it safely.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jun 2, 2021
@stale stale bot closed this as completed Jun 9, 2021
@Jeffwan Jeffwan reopened this Jul 5, 2021
@stale stale bot removed the lifecycle/stale label Jul 5, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 5, 2021

I just remove vendor folder but there're still something left like updating ./hack/update-codegen.sh. I don't want to mix them together because vendor deletion is a very large PR..

For rest of the changes, I will make it later. (probably want for development branch done unless there're urgent needs). Major reason is to minimize the code change and make merge smooth later

@gaocegege
Copy link
Member

Can we rename the issue since the vendor directory is already removed

@Jeffwan Jeffwan changed the title Remove vendor directory Clean up vendor dependencies Aug 19, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 19, 2021

Can we rename the issue since the vendor directory is already removed

Sounds good. I rename it

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants