-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up vendor dependencies #1162
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
1 similar comment
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
I did similar work for PyTorch and MXNet and I will take this one. |
Since we cannot remove it from the .git history to reduce the repo size, can we just keep it? |
@gaocegege I don't quite understand that. Do you mean the repo size won't drop after vendor clean up? I think if there's reasonable request on vendor mode, we can keep it. |
@gaocegege Well, technically it's possible to remove it from the history as well through git-filter-branch but can be dangerous. Unless there's strong reason to do that, e.g. accidentally pushed large files, we should refrain from doing so. We can probably keep it around if really needed. Though one can always just use generate it on his own. |
As you all know, vendor downloading in the Chinese mainland is sometimes affected for some unknown reasons. Thus prefer to keep it to make it easy for new contributors in China. |
@gaocegege Good point. Is there any good/reliable workaround for that? |
From our experience, we keep the vendor in git repository and check if it is updated in CI. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I agree on For China region, is there's a reliable GOPROXY people can use to speed up downloading? |
Yeah, I think so. We can remove it safely. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I just remove vendor folder but there're still something left like updating For rest of the changes, I will make it later. (probably want for development branch done unless there're urgent needs). Major reason is to minimize the code change and make merge smooth later |
Can we rename the issue since the vendor directory is already removed |
Sounds good. I rename it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
As we migrate from dep to go modules. There's no need to keep vendor redirectory.
however, In order to remove it, there're some prerequisite steps.
update-codegen.sh
to remove reference. Use code-generator from go mod.kube-openapi
in go pkg.The text was updated successfully, but these errors were encountered: