Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to upload artifact #1258

Closed
MartinForReal opened this issue Mar 18, 2021 · 6 comments
Closed

Add a step to upload artifact #1258

MartinForReal opened this issue Mar 18, 2021 · 6 comments

Comments

@MartinForReal
Copy link
Member

mirror issue: kubeflow/mpi-operator#342

@gaocegege
Copy link
Member

Should we follow the design here? https://github.com/kubeflow/community/blob/master/proposals/pvc-template.md

@MartinForReal
Copy link
Member Author

MartinForReal commented Mar 18, 2021

PVC works perfectly when it comes to storing training data, but it would be a little different when it comes to uploading output artifacts (such as model uploading) And S3 would be an more feasible option if we need to run jobs in multiple clusters and it would have less dependencies.
Also it works well with workflows because there is no way for argo controller to discover pvc provisioned by tfjob.

Do you think so? Any advice is appreciated. Thanks!

@Jeffwan
Copy link
Member

Jeffwan commented Mar 25, 2021

@MartinForReal I see your request in mpi-operator as well. Trying to understand if that's possible to add your logic in tfjob? Since KFP based training jobs uses launcher and that's not possible to leverage artifact feature. If you have some thoughts, feel free to draft a proposal

@stale
Copy link

stale bot commented Jun 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@johnugeorge
Copy link
Member

keeping it open for more discussions

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants