Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update presubmit and post submit job triggers #1354

Closed
Jeffwan opened this issue Aug 14, 2021 · 1 comment
Closed

Update presubmit and post submit job triggers #1354

Jeffwan opened this issue Aug 14, 2021 · 1 comment

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Aug 14, 2021

Presubmit

I notice /manifests change doesn't trigger CI pipeline which doesn't give us confidence on correctness.
https://github.com/kubeflow/tf-operator/blob/e78151fb989b219f516ce77d22f1bdbfb4821215/prow_config.yaml#L12-L27

We should make the changes to includes the manifest folder. This has not been updated for long time. It's better to revisit the settings and includes folder required CI pipeline.

Postsubmit

There're two options.

  1. trigger post submit job for every commit.
    Every time we release the image, we can pick up latest one.

https://github.com/kubeflow/tf-operator/blob/e78151fb989b219f516ce77d22f1bdbfb4821215/prow_config.yaml#L38-L53

  1. write a separate release workflow to build public images and release team could manually trigger the workflow.
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants