Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more CRD validations markers to block invalid job on client apply #1363

Closed
Jeffwan opened this issue Aug 14, 2021 · 2 comments
Closed

Add more CRD validations markers to block invalid job on client apply #1363

Jeffwan opened this issue Aug 14, 2021 · 2 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Aug 14, 2021

A follow up of #1362

If required item missing, we should fail the job submission on the client instead of only reporting errors on the server side.
Since we don't have plan to use web hook, we can use CRD validations. Please double check if all our requirement can be satisfied by using these markers.

https://book.kubebuilder.io/reference/markers/crd-validation.html

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 14, 2021

/kind enhancement

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants