Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch should provide a nightly image #1433

Closed
Jeffwan opened this issue Oct 3, 2021 · 4 comments
Closed

Master branch should provide a nightly image #1433

Jeffwan opened this issue Oct 3, 2021 · 4 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Oct 3, 2021

Even we enable post-job workflow to build the image for every commit, we have to manually update manifest to use latest tag.

This is inconvenient to use nightly image. In some situation, master manifest may use elder version than stable release branch. it totally depends on when we update the manifest.

We should make post submit job retag commit to nightly as well and push the image. In that case, master manifest should always use xxx:nightly.

kubectl apply -k "github.com/kubeflow/tf-operator.git/manifests/overlays/standalone?ref=master"
@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 3, 2021

/kind enhancement

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 3, 2021

/help

@google-oss-robot
Copy link

@Jeffwan:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants