Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create a Informer/ClientSet for PyTorch Jobs #1499

Closed
migueltol22 opened this issue Dec 3, 2021 · 5 comments · Fixed by #1610
Closed

[Feature] Create a Informer/ClientSet for PyTorch Jobs #1499

migueltol22 opened this issue Dec 3, 2021 · 5 comments · Fixed by #1610

Comments

@migueltol22
Copy link

Currently there is an informer and client for Tensorflow Jobs, however there isn't one for pytorch jobs. It'd be very beneficial to have a pytorch client/informer to be able to create/interact with pytorch jobs programmatically.

These all appear to be generated by client-gen so the work here shouldn't be too much.

@gaocegege
Copy link
Member

/cc @kubeflow/wg-training-leads

Yeah I think we should provide such a client/informer.

@terrytangyuan
Copy link
Member

terrytangyuan commented Dec 6, 2021

Yes this is nice to have to provide consistent experience. @migueltol22 Would you like to submit a PR?

@migueltol22
Copy link
Author

@terrytangyuan I began a PR here. Although after running the script there appear to be duplicates naming imports when referencing the pytorch and tensorflow generated code.
I haven't worked with code-gen before and didn't find much in the documentation. Do you happen to know what am I missing? Or is the expectation to manually fix these imports?

@gaocegege
Copy link
Member

Although after running the script there appear to be duplicates naming imports when referencing the pytorch and tensorflow generated code.

Can you please explain more about it?

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants